Parcourir la source

add comments for GAR

Mohammed Nafees il y a 3 ans
Parent
commit
df9e8d0cc8

+ 4 - 0
dashboard/src/main/home/integrations/create-integration/GARForm.tsx

@@ -61,6 +61,10 @@ const GARForm = (props: { closeForm: () => void }) => {
     try {
       let registryURL: string;
 
+      // GCP project IDs can have the ':' character like example.com:my-project
+      // if this is the case then we need to case on this
+      //
+      // see: https://cloud.google.com/artifact-registry/docs/docker/names#domain
       if (integration.gcp_project_id.includes(":")) {
         const domainProjectID = integration.gcp_project_id.split(":");
 

+ 4 - 0
dashboard/src/main/home/onboarding/steps/ConnectRegistry/forms/_GCPRegistryForm.tsx

@@ -377,6 +377,10 @@ export const GARegistryConfig: React.FC<{
 
     let registryURL: string;
 
+    // GCP project IDs can have the ':' character like example.com:my-project
+    // if this is the case then we need to case on this
+    //
+    // see: https://cloud.google.com/artifact-registry/docs/docker/names#domain
     if (gcpProjectId.includes(":")) {
       const domainProjectID = gcpProjectId.split(":");