Przeglądaj źródła

HandleRenameConfigMap: run `delete` after `create` to prevent data loss

Anukul Sangwan 5 lat temu
rodzic
commit
ce7a53039d
1 zmienionych plików z 5 dodań i 5 usunięć
  1. 5 5
      server/api/k8s_handler.go

+ 5 - 5
server/api/k8s_handler.go

@@ -625,11 +625,6 @@ func (app *App) HandleRenameConfigMap(w http.ResponseWriter, r *http.Request) {
 		decodedSecretData[k] = string(v)
 	}
 
-	if err := deleteConfigMap(agent, configMap.Name, configMap.Namespace); err != nil {
-		app.handleErrorInternal(err, w)
-		return
-	}
-
 	newConfigMap := &forms.ConfigMapForm{
 		Name:               renameConfigMapForm.NewName,
 		Namespace:          configMap.Namespace,
@@ -642,6 +637,11 @@ func (app *App) HandleRenameConfigMap(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
+	if err := deleteConfigMap(agent, configMap.Name, configMap.Namespace); err != nil {
+		app.handleErrorInternal(err, w)
+		return
+	}
+
 	if err := json.NewEncoder(w).Encode(newConfigMap); err != nil {
 		app.handleErrorFormDecoding(err, ErrEnvDecode, w)
 		return