Ver Fonte

Merge pull request #1438 from porter-dev/belanger/por-219-accept-invite-fix

[POR-219] Only overwrite redirect url for OAuth if set
abelanger5 há 4 anos atrás
pai
commit
c8a9625015
1 ficheiros alterados com 5 adições e 1 exclusões
  1. 5 1
      api/server/handlers/handler.go

+ 5 - 1
api/server/handlers/handler.go

@@ -90,7 +90,11 @@ func (d *DefaultPorterHandler) PopulateOAuthSession(w http.ResponseWriter, r *ht
 
 	// need state parameter to validate when redirected
 	session.Values["state"] = state
-	session.Values["redirect_uri"] = r.URL.Query().Get("redirect_uri")
+
+	// check if redirect uri is populated, then overwrite
+	if redirect := r.URL.Query().Get("redirect_uri"); redirect != "" {
+		session.Values["redirect_uri"] = redirect
+	}
 
 	if isProject {
 		project, _ := r.Context().Value(types.ProjectScope).(*models.Project)