Browse Source

adding error checks

Stefan McShane 3 years ago
parent
commit
9b02202997
3 changed files with 2 additions and 5 deletions
  1. 0 3
      .gitmodules
  2. 1 1
      cli/cmd/apply.go
  3. 1 1
      cli/cmd/apply_test.go

+ 0 - 3
.gitmodules

@@ -1,3 +0,0 @@
-[submodule "switchboard"]
-	path = switchboard
-	url = git@github.com:porter-dev/switchboard.git

+ 1 - 1
cli/cmd/apply.go

@@ -764,7 +764,7 @@ func NewDeploymentHook(conf DeploymentHookConfig) (DeploymentHook, error) {
 
 	res := DeploymentHook{
 		client:        conf.PorterAPIClient,
-		resourceGroup: conf.ResourceGroup,
+		resourceGroup: &conf.ResourceGroup,
 		namespace:     conf.Namespace,
 
 		projectID: uint(conf.ProjectID),

+ 1 - 1
cli/cmd/apply_test.go

@@ -25,7 +25,7 @@ func Test_Apply(t *testing.T) {
 		}
 		conf := DeploymentHookConfig{
 			PorterAPIClient: &cli,
-			ResourceGroup:   &switchboardTypes.ResourceGroup{},
+			ResourceGroup:   switchboardTypes.ResourceGroup{},
 			GithubAppID:     -1,
 			PullRequestID:   -1,
 			GithubActionID:  -1,