Parcourir la source

propagate app name to preview app definition (#4260)

ianedwards il y a 2 ans
Parent
commit
9617c10e08
1 fichiers modifiés avec 3 ajouts et 8 suppressions
  1. 3 8
      internal/porter_app/parse.go

+ 3 - 8
internal/porter_app/parse.go

@@ -71,14 +71,9 @@ func ParseYAML(ctx context.Context, porterYaml []byte, appName string) (v2.AppWi
 		}
 
 		appDefinition.AppProto.Name = appName
-
-		if appDefinition.PreviewApp != nil && appDefinition.PreviewApp.AppProto != nil {
-			if appDefinition.PreviewApp.AppProto.Name != "" && appDefinition.PreviewApp.AppProto.Name != appName {
-				telemetry.WithAttributes(span, telemetry.AttributeKV{Key: "parsed-preview-name", Value: appDefinition.PreviewApp.AppProto.Name})
-				return appDefinition, telemetry.Error(ctx, span, nil, "name specified in porter.yaml does not match preview app name")
-			}
-			appDefinition.PreviewApp.AppProto.Name = appName
-		}
+	}
+	if appDefinition.PreviewApp != nil && appDefinition.PreviewApp.AppProto != nil {
+		appDefinition.PreviewApp.AppProto.Name = appDefinition.AppProto.Name
 	}
 
 	return appDefinition, nil