Просмотр исходного кода

Implemented use memo and clone deep function to make sure that the form reference is not the same

jnfrati 4 лет назад
Родитель
Сommit
88b3ad3dcc

+ 3 - 3
dashboard/src/main/home/cluster-dashboard/expanded-chart/ExpandedJobChart.tsx

@@ -1,9 +1,9 @@
-import React, { useContext, useEffect, useRef, useState } from "react";
+import React, { useContext, useMemo, useState } from "react";
 import styled from "styled-components";
 import yaml from "js-yaml";
 
 import backArrow from "assets/back_arrow.png";
-import { merge, set } from "lodash";
+import { cloneDeep, set } from "lodash";
 import loading from "assets/loading.gif";
 
 import { ChartType, ClusterType } from "shared/types";
@@ -320,7 +320,7 @@ export const ExpandedJobChartFC: React.FC<{
     );
   }
 
-  const formData = { ...chart.form };
+  const formData = useMemo(() => cloneDeep(chart.form), [chart]);
 
   return (
     <>