wip

api/server/handlers/porter_app/service_status.go

@@ -137,13 +137,8 @@ func (c *ServiceStatusHandler) ServeHTTP(w http.ResponseWriter, r *http.Request)
 		return
 	}
 
-	appRevisions := listAppRevisionsResp.Msg.AppRevisions
-	if appRevisions == nil {
-		appRevisions = []*porterv1.AppRevision{}
-	}
-
 	var revisions []porter_app.Revision
-	for _, revision := range appRevisions {
+	for _, revision := range listAppRevisionsResp.Msg.AppRevisions {
 		encodedRevision, err := porter_app.EncodedRevisionFromProto(ctx, revision)
 		if err != nil {
 			err := telemetry.Error(ctx, span, err, "error getting encoded revision from proto")

dashboard/src/lib/hooks/useAppStatus.ts

@@ -26,11 +26,7 @@ const serviceStatusValidator = z.object({
       revision_number: z.number(),
       instance_status_list: z.array(
         z.object({
-          status: z.union([
-            z.literal("PENDING"),
-            z.literal("RUNNING"),
-            z.literal("FAILED"),
-          ]),
+          status: z.enum(["PENDING", "RUNNING", "FAILED"]),
           restart_count: z.number(),
           creation_timestamp: z.string(),
         })