Kaynağa Gözat

Answer 404 when pod is not found

jnfrati 4 yıl önce
ebeveyn
işleme
7d55ce491e
1 değiştirilmiş dosya ile 11 ekleme ve 1 silme
  1. 11 1
      api/server/handlers/namespace/get_pod.go

+ 11 - 1
api/server/handlers/namespace/get_pod.go

@@ -1,6 +1,8 @@
 package namespace
 
 import (
+	"errors"
+	"fmt"
 	"net/http"
 
 	"github.com/porter-dev/porter/api/server/authz"
@@ -10,6 +12,7 @@ import (
 	"github.com/porter-dev/porter/api/server/shared/config"
 	"github.com/porter-dev/porter/api/server/shared/requestutils"
 	"github.com/porter-dev/porter/api/types"
+	"github.com/porter-dev/porter/internal/kubernetes"
 	"github.com/porter-dev/porter/internal/models"
 )
 
@@ -54,7 +57,14 @@ func (c *GetPodHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 
 	pod, err := agent.GetPodByName(name, namespace)
 
-	if err != nil {
+	if targetErr := kubernetes.IsNotFoundError; errors.Is(err, targetErr) {
+		c.HandleAPIError(w, r, apierrors.NewErrPassThroughToClient(
+			fmt.Errorf("pod %s/%s was not found", namespace, name),
+			http.StatusNotFound,
+		))
+
+		return
+	} else if err != nil {
 		c.HandleAPIError(w, r, apierrors.NewErrInternal(err))
 		return
 	}