Prechádzať zdrojové kódy

Fix creation success reason showing incorrectly

jnfrati 3 rokov pred
rodič
commit
5d5ba9b3d9
1 zmenil súbory, kde vykonal 10 pridanie a 8 odobranie
  1. 10 8
      api/server/handlers/stack/create.go

+ 10 - 8
api/server/handlers/stack/create.go

@@ -221,16 +221,18 @@ func (p *StackCreateHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 				p.HandleAPIError(w, r, apierrors.NewErrInternal(err))
 				return
 			}
-		} else {
-			revision.Reason = "CreationSuccess"
-			revision.Message = "Stack deployed successfully"
+		}
+	}
 
-			revision, err = p.Repo().Stack().UpdateStackRevision(revision)
+	if revision.Status != string(types.StackRevisionStatusFailed) && len(revision.Reason) == 0 {
+		revision.Reason = "CreationSuccess"
+		revision.Message = "Stack deployed successfully"
 
-			if err != nil {
-				p.HandleAPIError(w, r, apierrors.NewErrInternal(err))
-				return
-			}
+		revision, err = p.Repo().Stack().UpdateStackRevision(revision)
+
+		if err != nil {
+			p.HandleAPIError(w, r, apierrors.NewErrInternal(err))
+			return
 		}
 	}