Explorar el Código

Merge pull request #1996 from porter-dev/belanger/fix-depl-status

Fix deployment status request on preview env deletion
abelanger5 hace 4 años
padre
commit
4ac3f2bc0f
Se han modificado 1 ficheros con 1 adiciones y 5 borrados
  1. 1 5
      api/server/handlers/webhook/github_incoming.go

+ 1 - 5
api/server/handlers/webhook/github_incoming.go

@@ -174,7 +174,7 @@ func (c *GithubIncomingWebhookHandler) deleteDeployment(
 		State: &state,
 		State: &state,
 	}
 	}
 
 
-	_, _, err = client.Repositories.CreateDeploymentStatus(
+	client.Repositories.CreateDeploymentStatus(
 		context.Background(),
 		context.Background(),
 		env.GitRepoOwner,
 		env.GitRepoOwner,
 		env.GitRepoName,
 		env.GitRepoName,
@@ -182,10 +182,6 @@ func (c *GithubIncomingWebhookHandler) deleteDeployment(
 		&deploymentStatusRequest,
 		&deploymentStatusRequest,
 	)
 	)
 
 
-	if err != nil {
-		return err
-	}
-
 	depl.Status = types.DeploymentStatusInactive
 	depl.Status = types.DeploymentStatusInactive
 
 
 	// update the deployment to mark it inactive
 	// update the deployment to mark it inactive