Ver Fonte

add more comments

Ian Edwards há 2 anos atrás
pai
commit
3de6b23c24

+ 3 - 0
api/server/handlers/deployment_target/delete.go

@@ -16,11 +16,13 @@ import (
 	"github.com/porter-dev/porter/internal/telemetry"
 )
 
+// DeleteDeploymentTargetHandler is the handler for DELETE /api/projects/{project_id}/clusters/{cluster_id}/deployment-targets/{deployment_target_id}
 type DeleteDeploymentTargetHandler struct {
 	handlers.PorterHandlerReadWriter
 	authz.KubernetesAgentGetter
 }
 
+// NewDeleteDeploymentTargetHandler creates a new DeleteDeploymentTargetHandler
 func NewDeleteDeploymentTargetHandler(
 	config *config.Config,
 	decoderValidator shared.RequestDecoderValidator,
@@ -32,6 +34,7 @@ func NewDeleteDeploymentTargetHandler(
 	}
 }
 
+// ServeHTTP deletes the deployment target from the cluster
 func (c *DeleteDeploymentTargetHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 	ctx, span := telemetry.NewSpan(r.Context(), "server-delete-deployment-target-by-id")
 	defer span.End()

+ 4 - 1
api/server/handlers/webhook/app_v2_github.go

@@ -18,6 +18,9 @@ import (
 	"github.com/porter-dev/porter/internal/telemetry"
 )
 
+// GithubPRStatus_Closed is the status for a closed PR (closed, merged)
+const GithubPRStatus_Closed = "closed"
+
 // GithubWebhookHandler handles webhooks sent to /api/webhooks/github/{project_id}/{cluster_id}/{porter_app_name}
 type GithubWebhookHandler struct {
 	handlers.PorterHandlerReadWriter
@@ -113,7 +116,7 @@ func (c *GithubWebhookHandler) ServeHTTP(w http.ResponseWriter, r *http.Request)
 
 	switch event := event.(type) {
 	case *github.PullRequestEvent:
-		if event.GetAction() != "closed" {
+		if event.GetAction() != GithubPRStatus_Closed {
 			c.WriteResult(w, r, nil)
 			return
 		}