update.go 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395
  1. /*
  2. Copyright 2018 The Kubernetes Authors.
  3. Licensed under the Apache License, Version 2.0 (the "License");
  4. you may not use this file except in compliance with the License.
  5. You may obtain a copy of the License at
  6. http://www.apache.org/licenses/LICENSE-2.0
  7. Unless required by applicable law or agreed to in writing, software
  8. distributed under the License is distributed on an "AS IS" BASIS,
  9. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  10. See the License for the specific language governing permissions and
  11. limitations under the License.
  12. */
  13. package merge
  14. import (
  15. "fmt"
  16. "sigs.k8s.io/structured-merge-diff/v6/fieldpath"
  17. "sigs.k8s.io/structured-merge-diff/v6/typed"
  18. "sigs.k8s.io/structured-merge-diff/v6/value"
  19. )
  20. // Converter is an interface to the conversion logic. The converter
  21. // needs to be able to convert objects from one version to another.
  22. type Converter interface {
  23. Convert(object *typed.TypedValue, version fieldpath.APIVersion) (*typed.TypedValue, error)
  24. IsMissingVersionError(error) bool
  25. }
  26. // UpdateBuilder allows you to create a new Updater by exposing all of
  27. // the options and setting them once.
  28. type UpdaterBuilder struct {
  29. Converter Converter
  30. IgnoreFilter map[fieldpath.APIVersion]fieldpath.Filter
  31. // IgnoredFields provides a set of fields to ignore for each
  32. IgnoredFields map[fieldpath.APIVersion]*fieldpath.Set
  33. // Stop comparing the new object with old object after applying.
  34. // This was initially used to avoid spurious etcd update, but
  35. // since that's vastly inefficient, we've come-up with a better
  36. // way of doing that. Create this flag to stop it.
  37. // Comparing has become more expensive too now that we're not using
  38. // `Compare` but `value.Equals` so this gives an option to avoid it.
  39. ReturnInputOnNoop bool
  40. }
  41. func (u *UpdaterBuilder) BuildUpdater() *Updater {
  42. return &Updater{
  43. Converter: u.Converter,
  44. IgnoreFilter: u.IgnoreFilter,
  45. IgnoredFields: u.IgnoredFields,
  46. returnInputOnNoop: u.ReturnInputOnNoop,
  47. }
  48. }
  49. // Updater is the object used to compute updated FieldSets and also
  50. // merge the object on Apply.
  51. type Updater struct {
  52. // Deprecated: This will eventually become private.
  53. Converter Converter
  54. // Deprecated: This will eventually become private.
  55. IgnoredFields map[fieldpath.APIVersion]*fieldpath.Set
  56. // Deprecated: This will eventually become private.
  57. IgnoreFilter map[fieldpath.APIVersion]fieldpath.Filter
  58. returnInputOnNoop bool
  59. }
  60. func (s *Updater) update(oldObject, newObject *typed.TypedValue, version fieldpath.APIVersion, managers fieldpath.ManagedFields, workflow string, force bool) (fieldpath.ManagedFields, *typed.Comparison, error) {
  61. conflicts := fieldpath.ManagedFields{}
  62. removed := fieldpath.ManagedFields{}
  63. compare, err := oldObject.Compare(newObject)
  64. if err != nil {
  65. return nil, nil, fmt.Errorf("failed to compare objects: %v", err)
  66. }
  67. var versions map[fieldpath.APIVersion]*typed.Comparison
  68. if s.IgnoredFields != nil && s.IgnoreFilter != nil {
  69. return nil, nil, fmt.Errorf("IgnoreFilter and IgnoreFilter may not both be set")
  70. }
  71. if s.IgnoredFields != nil {
  72. versions = map[fieldpath.APIVersion]*typed.Comparison{
  73. version: compare.ExcludeFields(s.IgnoredFields[version]),
  74. }
  75. } else {
  76. versions = map[fieldpath.APIVersion]*typed.Comparison{
  77. version: compare.FilterFields(s.IgnoreFilter[version]),
  78. }
  79. }
  80. for manager, managerSet := range managers {
  81. if manager == workflow {
  82. continue
  83. }
  84. compare, ok := versions[managerSet.APIVersion()]
  85. if !ok {
  86. var err error
  87. versionedOldObject, err := s.Converter.Convert(oldObject, managerSet.APIVersion())
  88. if err != nil {
  89. if s.Converter.IsMissingVersionError(err) {
  90. delete(managers, manager)
  91. continue
  92. }
  93. return nil, nil, fmt.Errorf("failed to convert old object: %v", err)
  94. }
  95. versionedNewObject, err := s.Converter.Convert(newObject, managerSet.APIVersion())
  96. if err != nil {
  97. if s.Converter.IsMissingVersionError(err) {
  98. delete(managers, manager)
  99. continue
  100. }
  101. return nil, nil, fmt.Errorf("failed to convert new object: %v", err)
  102. }
  103. compare, err = versionedOldObject.Compare(versionedNewObject)
  104. if err != nil {
  105. return nil, nil, fmt.Errorf("failed to compare objects: %v", err)
  106. }
  107. if s.IgnoredFields != nil {
  108. versions[managerSet.APIVersion()] = compare.ExcludeFields(s.IgnoredFields[managerSet.APIVersion()])
  109. } else {
  110. versions[managerSet.APIVersion()] = compare.FilterFields(s.IgnoreFilter[managerSet.APIVersion()])
  111. }
  112. }
  113. conflictSet := managerSet.Set().Intersection(compare.Modified.Union(compare.Added))
  114. if !conflictSet.Empty() {
  115. conflicts[manager] = fieldpath.NewVersionedSet(conflictSet, managerSet.APIVersion(), false)
  116. }
  117. if !compare.Removed.Empty() {
  118. removed[manager] = fieldpath.NewVersionedSet(compare.Removed, managerSet.APIVersion(), false)
  119. }
  120. }
  121. if !force && len(conflicts) != 0 {
  122. return nil, nil, ConflictsFromManagers(conflicts)
  123. }
  124. for manager, conflictSet := range conflicts {
  125. managers[manager] = fieldpath.NewVersionedSet(managers[manager].Set().Difference(conflictSet.Set()), managers[manager].APIVersion(), managers[manager].Applied())
  126. }
  127. for manager, removedSet := range removed {
  128. managers[manager] = fieldpath.NewVersionedSet(managers[manager].Set().Difference(removedSet.Set()), managers[manager].APIVersion(), managers[manager].Applied())
  129. }
  130. for manager := range managers {
  131. if managers[manager].Set().Empty() {
  132. delete(managers, manager)
  133. }
  134. }
  135. return managers, compare, nil
  136. }
  137. // Update is the method you should call once you've merged your final
  138. // object on CREATE/UPDATE/PATCH verbs. newObject must be the object
  139. // that you intend to persist (after applying the patch if this is for a
  140. // PATCH call), and liveObject must be the original object (empty if
  141. // this is a CREATE call).
  142. func (s *Updater) Update(liveObject, newObject *typed.TypedValue, version fieldpath.APIVersion, managers fieldpath.ManagedFields, manager string) (*typed.TypedValue, fieldpath.ManagedFields, error) {
  143. var err error
  144. managers, err = s.reconcileManagedFieldsWithSchemaChanges(liveObject, managers)
  145. if err != nil {
  146. return nil, fieldpath.ManagedFields{}, err
  147. }
  148. managers, compare, err := s.update(liveObject, newObject, version, managers, manager, true)
  149. if err != nil {
  150. return nil, fieldpath.ManagedFields{}, err
  151. }
  152. if _, ok := managers[manager]; !ok {
  153. managers[manager] = fieldpath.NewVersionedSet(fieldpath.NewSet(), version, false)
  154. }
  155. set := managers[manager].Set().Difference(compare.Removed).Union(compare.Modified).Union(compare.Added)
  156. if s.IgnoredFields != nil && s.IgnoreFilter != nil {
  157. return nil, nil, fmt.Errorf("IgnoreFilter and IgnoreFilter may not both be set")
  158. }
  159. var ignoreFilter fieldpath.Filter
  160. if s.IgnoredFields != nil {
  161. ignoreFilter = fieldpath.NewExcludeSetFilter(s.IgnoredFields[version])
  162. } else {
  163. ignoreFilter = s.IgnoreFilter[version]
  164. }
  165. if ignoreFilter != nil {
  166. set = ignoreFilter.Filter(set)
  167. }
  168. managers[manager] = fieldpath.NewVersionedSet(
  169. set,
  170. version,
  171. false,
  172. )
  173. if managers[manager].Set().Empty() {
  174. delete(managers, manager)
  175. }
  176. return newObject, managers, nil
  177. }
  178. // Apply should be called when Apply is run, given the current object as
  179. // well as the configuration that is applied. This will merge the object
  180. // and return it.
  181. func (s *Updater) Apply(liveObject, configObject *typed.TypedValue, version fieldpath.APIVersion, managers fieldpath.ManagedFields, manager string, force bool) (*typed.TypedValue, fieldpath.ManagedFields, error) {
  182. var err error
  183. managers, err = s.reconcileManagedFieldsWithSchemaChanges(liveObject, managers)
  184. if err != nil {
  185. return nil, fieldpath.ManagedFields{}, err
  186. }
  187. newObject, err := liveObject.Merge(configObject)
  188. if err != nil {
  189. return nil, fieldpath.ManagedFields{}, fmt.Errorf("failed to merge config: %v", err)
  190. }
  191. lastSet := managers[manager]
  192. set, err := configObject.ToFieldSet()
  193. if err != nil {
  194. return nil, fieldpath.ManagedFields{}, fmt.Errorf("failed to get field set: %v", err)
  195. }
  196. if s.IgnoredFields != nil && s.IgnoreFilter != nil {
  197. return nil, nil, fmt.Errorf("IgnoreFilter and IgnoreFilter may not both be set")
  198. }
  199. var ignoreFilter fieldpath.Filter
  200. if s.IgnoredFields != nil {
  201. ignoreFilter = fieldpath.NewExcludeSetFilter(s.IgnoredFields[version])
  202. } else {
  203. ignoreFilter = s.IgnoreFilter[version]
  204. }
  205. if ignoreFilter != nil {
  206. set = ignoreFilter.Filter(set)
  207. }
  208. managers[manager] = fieldpath.NewVersionedSet(set, version, true)
  209. newObject, err = s.prune(newObject, managers, manager, lastSet)
  210. if err != nil {
  211. return nil, fieldpath.ManagedFields{}, fmt.Errorf("failed to prune fields: %v", err)
  212. }
  213. managers, _, err = s.update(liveObject, newObject, version, managers, manager, force)
  214. if err != nil {
  215. return nil, fieldpath.ManagedFields{}, err
  216. }
  217. if !s.returnInputOnNoop && value.EqualsUsing(value.NewFreelistAllocator(), liveObject.AsValue(), newObject.AsValue()) {
  218. newObject = nil
  219. }
  220. return newObject, managers, nil
  221. }
  222. // prune will remove a field, list or map item, iff:
  223. // * applyingManager applied it last time
  224. // * applyingManager didn't apply it this time
  225. // * no other applier claims to manage it
  226. func (s *Updater) prune(merged *typed.TypedValue, managers fieldpath.ManagedFields, applyingManager string, lastSet fieldpath.VersionedSet) (*typed.TypedValue, error) {
  227. if lastSet == nil || lastSet.Set().Empty() {
  228. return merged, nil
  229. }
  230. version := lastSet.APIVersion()
  231. convertedMerged, err := s.Converter.Convert(merged, version)
  232. if err != nil {
  233. if s.Converter.IsMissingVersionError(err) {
  234. return merged, nil
  235. }
  236. return nil, fmt.Errorf("failed to convert merged object to last applied version: %v", err)
  237. }
  238. sc, tr := convertedMerged.Schema(), convertedMerged.TypeRef()
  239. pruned := convertedMerged.RemoveItems(lastSet.Set().EnsureNamedFieldsAreMembers(sc, tr))
  240. pruned, err = s.addBackOwnedItems(convertedMerged, pruned, version, managers, applyingManager)
  241. if err != nil {
  242. return nil, fmt.Errorf("failed add back owned items: %v", err)
  243. }
  244. pruned, err = s.addBackDanglingItems(convertedMerged, pruned, lastSet)
  245. if err != nil {
  246. return nil, fmt.Errorf("failed add back dangling items: %v", err)
  247. }
  248. return s.Converter.Convert(pruned, managers[applyingManager].APIVersion())
  249. }
  250. // addBackOwnedItems adds back any fields, list and map items that were removed by prune,
  251. // but other appliers or updaters (or the current applier's new config) claim to own.
  252. func (s *Updater) addBackOwnedItems(merged, pruned *typed.TypedValue, prunedVersion fieldpath.APIVersion, managedFields fieldpath.ManagedFields, applyingManager string) (*typed.TypedValue, error) {
  253. var err error
  254. managedAtVersion := map[fieldpath.APIVersion]*fieldpath.Set{}
  255. for _, managerSet := range managedFields {
  256. if _, ok := managedAtVersion[managerSet.APIVersion()]; !ok {
  257. managedAtVersion[managerSet.APIVersion()] = fieldpath.NewSet()
  258. }
  259. managedAtVersion[managerSet.APIVersion()] = managedAtVersion[managerSet.APIVersion()].Union(managerSet.Set())
  260. }
  261. // Add back owned items at pruned version first to avoid conversion failure
  262. // caused by pruned fields which are required for conversion.
  263. if managed, ok := managedAtVersion[prunedVersion]; ok {
  264. merged, pruned, err = s.addBackOwnedItemsForVersion(merged, pruned, prunedVersion, managed)
  265. if err != nil {
  266. return nil, err
  267. }
  268. delete(managedAtVersion, prunedVersion)
  269. }
  270. for version, managed := range managedAtVersion {
  271. merged, pruned, err = s.addBackOwnedItemsForVersion(merged, pruned, version, managed)
  272. if err != nil {
  273. return nil, err
  274. }
  275. }
  276. return pruned, nil
  277. }
  278. // addBackOwnedItemsForVersion adds back any fields, list and map items that were removed by prune with specific managed field path at a version.
  279. // It is an extracted sub-function from addBackOwnedItems for code reuse.
  280. func (s *Updater) addBackOwnedItemsForVersion(merged, pruned *typed.TypedValue, version fieldpath.APIVersion, managed *fieldpath.Set) (*typed.TypedValue, *typed.TypedValue, error) {
  281. var err error
  282. merged, err = s.Converter.Convert(merged, version)
  283. if err != nil {
  284. if s.Converter.IsMissingVersionError(err) {
  285. return merged, pruned, nil
  286. }
  287. return nil, nil, fmt.Errorf("failed to convert merged object at version %v: %v", version, err)
  288. }
  289. pruned, err = s.Converter.Convert(pruned, version)
  290. if err != nil {
  291. if s.Converter.IsMissingVersionError(err) {
  292. return merged, pruned, nil
  293. }
  294. return nil, nil, fmt.Errorf("failed to convert pruned object at version %v: %v", version, err)
  295. }
  296. mergedSet, err := merged.ToFieldSet()
  297. if err != nil {
  298. return nil, nil, fmt.Errorf("failed to create field set from merged object at version %v: %v", version, err)
  299. }
  300. prunedSet, err := pruned.ToFieldSet()
  301. if err != nil {
  302. return nil, nil, fmt.Errorf("failed to create field set from pruned object at version %v: %v", version, err)
  303. }
  304. sc, tr := merged.Schema(), merged.TypeRef()
  305. pruned = merged.RemoveItems(mergedSet.EnsureNamedFieldsAreMembers(sc, tr).Difference(prunedSet.EnsureNamedFieldsAreMembers(sc, tr).Union(managed.EnsureNamedFieldsAreMembers(sc, tr))))
  306. return merged, pruned, nil
  307. }
  308. // addBackDanglingItems makes sure that the fields list and map items removed by prune were
  309. // previously owned by the currently applying manager. This will add back fields list and map items
  310. // that are unowned or that are owned by Updaters and shouldn't be removed.
  311. func (s *Updater) addBackDanglingItems(merged, pruned *typed.TypedValue, lastSet fieldpath.VersionedSet) (*typed.TypedValue, error) {
  312. convertedPruned, err := s.Converter.Convert(pruned, lastSet.APIVersion())
  313. if err != nil {
  314. if s.Converter.IsMissingVersionError(err) {
  315. return merged, nil
  316. }
  317. return nil, fmt.Errorf("failed to convert pruned object to last applied version: %v", err)
  318. }
  319. prunedSet, err := convertedPruned.ToFieldSet()
  320. if err != nil {
  321. return nil, fmt.Errorf("failed to create field set from pruned object in last applied version: %v", err)
  322. }
  323. mergedSet, err := merged.ToFieldSet()
  324. if err != nil {
  325. return nil, fmt.Errorf("failed to create field set from merged object in last applied version: %v", err)
  326. }
  327. sc, tr := merged.Schema(), merged.TypeRef()
  328. prunedSet = prunedSet.EnsureNamedFieldsAreMembers(sc, tr)
  329. mergedSet = mergedSet.EnsureNamedFieldsAreMembers(sc, tr)
  330. last := lastSet.Set().EnsureNamedFieldsAreMembers(sc, tr)
  331. return merged.RemoveItems(mergedSet.Difference(prunedSet).Intersection(last)), nil
  332. }
  333. // reconcileManagedFieldsWithSchemaChanges reconciles the managed fields with any changes to the
  334. // object's schema since the managed fields were written.
  335. //
  336. // Supports:
  337. // - changing types from atomic to granular
  338. // - changing types from granular to atomic
  339. func (s *Updater) reconcileManagedFieldsWithSchemaChanges(liveObject *typed.TypedValue, managers fieldpath.ManagedFields) (fieldpath.ManagedFields, error) {
  340. result := fieldpath.ManagedFields{}
  341. for manager, versionedSet := range managers {
  342. tv, err := s.Converter.Convert(liveObject, versionedSet.APIVersion())
  343. if s.Converter.IsMissingVersionError(err) { // okay to skip, obsolete versions will be deleted automatically anyway
  344. continue
  345. }
  346. if err != nil {
  347. return nil, err
  348. }
  349. reconciled, err := typed.ReconcileFieldSetWithSchema(versionedSet.Set(), tv)
  350. if err != nil {
  351. return nil, err
  352. }
  353. if reconciled != nil {
  354. result[manager] = fieldpath.NewVersionedSet(reconciled, versionedSet.APIVersion(), versionedSet.Applied())
  355. } else {
  356. result[manager] = versionedSet
  357. }
  358. }
  359. return result, nil
  360. }