Răsfoiți Sursa

Merge pull request #2261 from opencost/v1.107-patch/big-query-nil-iter

fix bug where err is not returned from query
Sean Holcomb 2 ani în urmă
părinte
comite
e28f59b074
1 a modificat fișierele cu 6 adăugiri și 2 ștergeri
  1. 6 2
      pkg/cloud/gcp/bigqueryquerier.go

+ 6 - 2
pkg/cloud/gcp/bigqueryquerier.go

@@ -2,6 +2,7 @@ package gcp
 
 import (
 	"context"
+	"fmt"
 
 	"cloud.google.com/go/bigquery"
 	"github.com/opencost/opencost/pkg/cloud"
@@ -50,9 +51,12 @@ func (bqq *BigQueryQuerier) Query(ctx context.Context, queryStr string) (*bigque
 	// If result is empty and connection status is not already successful update status to missing data
 	if iter == nil && bqq.ConnectionStatus != cloud.SuccessfulConnection {
 		bqq.ConnectionStatus = cloud.MissingData
-		return iter, nil
+	} else {
+		bqq.ConnectionStatus = cloud.SuccessfulConnection
 	}
 
-	bqq.ConnectionStatus = cloud.SuccessfulConnection
+	if err != nil {
+		return iter, fmt.Errorf("BigQueryQuerier: Query: error reading query results: %w", err)
+	}
 	return iter, nil
 }