Browse Source

Memory Leak Fix (#3179)

Signed-off-by: Matt Bolt <mbolt35@gmail.com>
Matt Bolt 11 months ago
parent
commit
d8b78b8854
2 changed files with 5 additions and 1 deletions
  1. 3 1
      core/pkg/nodestats/nodes_test.go
  2. 2 0
      core/pkg/nodestats/nodestats.go

+ 3 - 1
core/pkg/nodestats/nodes_test.go

@@ -12,7 +12,9 @@ import (
 	"k8s.io/client-go/kubernetes"
 )
 
-func TestNodeSummaryStuff(t *testing.T) {
+func TestNodeSummaryLive(t *testing.T) {
+	// this requires a live kubernetes cluster, and is used to test live functionality
+	// we can comment the skip if we integrate a k8s sim or a mock server in the future
 	t.Skip("Skipping live test for node summary client")
 
 	client, err := kubeconfig.LoadKubeClient("")

+ 2 - 0
core/pkg/nodestats/nodestats.go

@@ -73,6 +73,8 @@ func (nssc *NodeStatsSummaryClient) GetNodeData() ([]*stats.Summary, error) {
 			return nil
 		}
 
+		defer resp.Body.Close()
+
 		data, err := nodeResponseToStatSummary(resp)
 		if err != nil {
 			log.Warnf("error converting node data: %s", err)