Просмотр исходного кода

Log Panics, Pull APP_VERSION from env vars

(cherry picked from commit 55a213e56d179a6c52144303e05d9cb6360d6a92)
Matt Bolt 5 лет назад
Родитель
Сommit
784cf8734c
2 измененных файлов с 11 добавлено и 2 удалено
  1. 3 2
      pkg/costmodel/router.go
  2. 8 0
      pkg/env/costmodelenv.go

+ 3 - 2
pkg/costmodel/router.go

@@ -681,6 +681,7 @@ type ConfigWatchers struct {
 // captures the panic event in sentry
 func capturePanicEvent(err string, stack string) {
 	msg := fmt.Sprintf("Panic: %s\nStackTrace: %s\n", err, stack)
+	klog.V(1).Infoln(msg)
 	sentry.CurrentHub().CaptureEvent(&sentry.Event{
 		Level:   sentry.LevelError,
 		Message: msg,
@@ -711,11 +712,11 @@ func Initialize(additionalConfigWatchers ...ConfigWatchers) {
 	klog.InitFlags(nil)
 	flag.Set("v", "3")
 	flag.Parse()
-	klog.V(1).Infof("Starting cost-model (git commit \"%s\")", gitCommit)
+	klog.V(1).Infof("Starting cost-model (git commit \"%s\")", env.GetAppVersion())
 
 	var err error
 	if errorReportingEnabled {
-		err = sentry.Init(sentry.ClientOptions{Release: gitCommit})
+		err = sentry.Init(sentry.ClientOptions{Release: env.GetAppVersion()})
 		if err != nil {
 			klog.Infof("Failed to initialize sentry for error reporting")
 		} else {

+ 8 - 0
pkg/env/costmodelenv.go

@@ -1,6 +1,8 @@
 package env
 
 const (
+	AppVersionEnvVar = "APP_VERSION"
+
 	AWSAccessKeyIDEnvVar     = "AWS_ACCESS_KEY_ID"
 	AWSAccessKeySecretEnvVar = "AWS_SECRET_ACCESS_KEY"
 	AWSClusterIDEnvVar       = "AWS_CLUSTER_ID"
@@ -42,6 +44,12 @@ const (
 	KubeConfigPathEnvVar = "KUBECONFIG_PATH"
 )
 
+// GetAWSAccessKeyID returns the environment variable value for AWSAccessKeyIDEnvVar which represents
+// the AWS access key for authentication
+func GetAppVersion() string {
+	return Get(AppVersionEnvVar, "Pre-1.68.0")
+}
+
 // GetAWSAccessKeyID returns the environment variable value for AWSAccessKeyIDEnvVar which represents
 // the AWS access key for authentication
 func GetAWSAccessKeyID() string {