Bläddra i källkod

setting default to __unknown__ and also making references to new metrics kubecost_pv_info

Signed-off-by: Alan Rodrigues <alanr5691@yahoo.com>
Alan Rodrigues 3 år sedan
förälder
incheckning
6d8d55c8ec
3 ändrade filer med 4 tillägg och 4 borttagningar
  1. 2 2
      pkg/costmodel/cluster.go
  2. 1 1
      pkg/kubecost/asset.go
  3. 1 1
      pkg/kubecost/kubecost_codecs.go

+ 2 - 2
pkg/costmodel/cluster.go

@@ -305,7 +305,7 @@ func ClusterDisks(client prometheus.Client, provider cloud.Provider, start, end
 		diskMap[key].Minutes = mins
 	}
 
-	//Iterating through Persistent Volume given by kube_persistentvolumeclaim_info and assign the storage class if known and unknown if not known.
+	//Iterating through Persistent Volume given by custom metrics kubecost_pv_info and assign the storage class if known and __unknown__ if not populated.
 	for _, result := range resPVStorageClass {
 		cluster, err := result.GetString(env.GetPromClusterLabel())
 		if err != nil {
@@ -342,7 +342,7 @@ func ClusterDisks(client prometheus.Client, provider cloud.Provider, start, end
 			disk.ProviderID = disk.Name
 		}
 
-		// Explicitly specify unknown storage class for disk whose information is unavailable in prometheus metrics of kube_persistentvolumeclaim_info
+		// Explicitly specify unknown storage class for disk whose information is unavailable in prometheus metrics of kubecost_pv_info
 		if disk.StorageClass == "" {
 			disk.StorageClass = kubecost.UnknownStorageClass
 		}

+ 1 - 1
pkg/kubecost/asset.go

@@ -1069,7 +1069,7 @@ type Disk struct {
 	ByteHours    float64
 	Local        float64
 	Breakdown    *Breakdown
-	StorageClass string // @bingen:field[version=17]
+	StorageClass string // @bingen:field[version=17, default=__unknown__]
 }
 
 // NewDisk creates and returns a new Disk Asset

+ 1 - 1
pkg/kubecost/kubecost_codecs.go

@@ -5159,7 +5159,7 @@ func (target *Disk) UnmarshalBinaryWithContext(ctx *DecodingContext) (err error)
 		target.StorageClass = aa
 
 	} else {
-		target.StorageClass = "" // default
+		target.StorageClass = "__unknown__" // default
 	}
 
 	return nil