Ajay tripathy remove 2d cache (#668)

* simple pvfix

* Update to latest bingen read optimizations by allocating the required map space ahead of time. Apply to Properties as well.

* A few more smaller optimizations on Clone()

* fix extra PVlookups

* remove 2d cache

Co-authored-by: Matt Bolt <mbolt35@gmail.com>

pkg/costmodel/aggregation.go

@@ -1819,26 +1819,26 @@ func (a *Accesses) warmAggregateCostModelCache() {
 		}
 	}(sem)
 
-	// 2 day
-	go func(sem *util.Semaphore) {
-		defer errors.HandlePanic()
+	if !env.IsETLEnabled() {
+		// 2 day
+		go func(sem *util.Semaphore) {
+			defer errors.HandlePanic()
 
-		duration := "2d"
-		offset := "1m"
-		durHrs := "48h"
-		dur := 2 * 24 * time.Hour
+			duration := "2d"
+			offset := "1m"
+			durHrs := "48h"
+			dur := 2 * 24 * time.Hour
 
-		for {
-			sem.Acquire()
-			warmFunc(duration, durHrs, offset, false)
-			sem.Return()
+			for {
+				sem.Acquire()
+				warmFunc(duration, durHrs, offset, false)
+				sem.Return()
 
-			log.Infof("aggregation: warm cache: %s", duration)
-			time.Sleep(a.GetCacheRefresh(dur))
-		}
-	}(sem)
+				log.Infof("aggregation: warm cache: %s", duration)
+				time.Sleep(a.GetCacheRefresh(dur))
+			}
+		}(sem)
 
-	if !env.IsETLEnabled() {
 		// 7 day
 		go func(sem *util.Semaphore) {
 			defer errors.HandlePanic()