Explorar el Código

Revert "Log Panics, AppVersion"

Matt Bolt hace 5 años
padre
commit
2a297f160d
Se han modificado 2 ficheros con 2 adiciones y 11 borrados
  1. 2 3
      pkg/costmodel/router.go
  2. 0 8
      pkg/env/costmodelenv.go

+ 2 - 3
pkg/costmodel/router.go

@@ -688,7 +688,6 @@ type ConfigWatchers struct {
 // captures the panic event in sentry
 func capturePanicEvent(err string, stack string) {
 	msg := fmt.Sprintf("Panic: %s\nStackTrace: %s\n", err, stack)
-	klog.V(1).Infoln(msg)
 	sentry.CurrentHub().CaptureEvent(&sentry.Event{
 		Level:   sentry.LevelError,
 		Message: msg,
@@ -719,11 +718,11 @@ func Initialize(additionalConfigWatchers ...ConfigWatchers) {
 	klog.InitFlags(nil)
 	flag.Set("v", "3")
 	flag.Parse()
-	klog.V(1).Infof("Starting cost-model (git commit \"%s\")", env.GetAppVersion())
+	klog.V(1).Infof("Starting cost-model (git commit \"%s\")", gitCommit)
 
 	var err error
 	if errorReportingEnabled {
-		err = sentry.Init(sentry.ClientOptions{Release: env.GetAppVersion()})
+		err = sentry.Init(sentry.ClientOptions{Release: gitCommit})
 		if err != nil {
 			klog.Infof("Failed to initialize sentry for error reporting")
 		} else {

+ 0 - 8
pkg/env/costmodelenv.go

@@ -1,8 +1,6 @@
 package env
 
 const (
-	AppVersionEnvVar = "APP_VERSION"
-
 	AWSAccessKeyIDEnvVar     = "AWS_ACCESS_KEY_ID"
 	AWSAccessKeySecretEnvVar = "AWS_SECRET_ACCESS_KEY"
 	AWSClusterIDEnvVar       = "AWS_CLUSTER_ID"
@@ -44,12 +42,6 @@ const (
 	KubeConfigPathEnvVar = "KUBECONFIG_PATH"
 )
 
-// GetAWSAccessKeyID returns the environment variable value for AWSAccessKeyIDEnvVar which represents
-// the AWS access key for authentication
-func GetAppVersion() string {
-	return Get(AppVersionEnvVar, "Pre-1.68.0")
-}
-
 // GetAWSAccessKeyID returns the environment variable value for AWSAccessKeyIDEnvVar which represents
 // the AWS access key for authentication
 func GetAWSAccessKeyID() string {