소스 검색

Added explanations as to how GCP and Azure region lists were obtained. Also updated Azure region list.

Neal Ormsbee 4 년 전
부모
커밋
0ca84abefb
2개의 변경된 파일13개의 추가작업 그리고 1개의 파일을 삭제
  1. 10 1
      pkg/cloud/azureprovider.go
  2. 3 0
      pkg/cloud/gcpprovider.go

+ 10 - 1
pkg/cloud/azureprovider.go

@@ -73,6 +73,9 @@ var (
 	mtStandardN, _ = regexp.Compile(`^Standard_N[C|D|V]\d+r?[_v\d]*[_Promo]*$`)
 )
 
+// List obtained by installing the Azure CLI tool "az", described here:
+// https://docs.microsoft.com/en-us/cli/azure/install-azure-cli-linux?pivots=apt
+// logging into an Azure account, and running command `az account list-locations`
 var azureRegions = []string{
 	"eastus",
 	"eastus2",
@@ -114,9 +117,16 @@ var azureRegions = []string{
 	"brazil",
 	"canada",
 	"europe",
+	"france",
+	"germany",
 	"global",
 	"india",
 	"japan",
+	"korea",
+	"norway",
+	"southafrica",
+	"switzerland",
+	"uae",
 	"uk",
 	"unitedstates",
 	"eastasiastage",
@@ -137,7 +147,6 @@ var azureRegions = []string{
 	"francesouth",
 	"germanynorth",
 	"norwaywest",
-	"swedensouth",
 	"switzerlandwest",
 	"ukwest",
 	"uaecentral",

+ 3 - 0
pkg/cloud/gcpprovider.go

@@ -34,6 +34,9 @@ import (
 const GKE_GPU_TAG = "cloud.google.com/gke-accelerator"
 const BigqueryUpdateType = "bigqueryupdate"
 
+// List obtained by installing the `gcloud` CLI tool,
+// logging into gcp account, and running command
+// `gcloud compute regions list`
 var gcpRegions = []string{
 	"asia-east1",
 	"asia-east2",