Remove extra start command for the replicator service

This patch makes sure that the replicator service is not being started
twice, by removing the `start()` call, but also making sure that it sets
explicit `start=True` for `create_service`, to account for future changes
in the method kwarg defaults.

coriolis/providers/replicator.py

@@ -739,7 +739,7 @@ class Replicator(object):
                    })
         utils.create_service(
             ssh, cmdline, REPLICATOR_SVC_NAME,
-            run_as=REPLICATOR_USERNAME)
+            run_as=REPLICATOR_USERNAME, start=True)
 
     def _fetch_remote_file(self, ssh, remote_file, local_file):
         # TODO(gsamfira): make this re-usable
@@ -860,7 +860,6 @@ class Replicator(object):
         certs = self._setup_certificates(ssh, args)
         self._exec_replicator(
             ssh, args["port"], certs["remote"], REPLICATOR_STATE)
-        self.start()
         return certs["local"]
 
     def _get_size_from_chunks(self, chunks):

coriolis/tests/providers/test_replicator.py

@@ -1025,7 +1025,9 @@ class ReplicatorTestCase(test_base.CoriolisBaseTestCase):
         mock_create_service.assert_called_once_with(
             self._ssh, mock.ANY,
             replicator_module.REPLICATOR_SVC_NAME,
-            run_as=replicator_module.REPLICATOR_USERNAME)
+            run_as=replicator_module.REPLICATOR_USERNAME,
+            start=True,
+        )
 
     @mock.patch.object(replicator_module.utils, 'read_ssh_file')
     def test__fetch_remote_file(self, mock_read_ssh_file):
@@ -1107,9 +1109,8 @@ class ReplicatorTestCase(test_base.CoriolisBaseTestCase):
     @mock.patch.object(replicator_module.Replicator, '_setup_replicator_user')
     @mock.patch.object(replicator_module.Replicator, '_setup_certificates')
     @mock.patch.object(replicator_module.Replicator, '_exec_replicator')
-    @mock.patch.object(replicator_module.Replicator, 'start')
     def test__setup_replicator(
-            self, mock_start, mock_exec_replicator, mock_setup_certificates,
+            self, mock_exec_replicator, mock_setup_certificates,
             mock_setup_replicator_user, mock_reconnect_ssh,
             mock_setup_replicator_group, mock_copy_replicator_cmd,
             mock_parse_replicator_conn_info, mock_os_remove,
@@ -1154,7 +1155,6 @@ class ReplicatorTestCase(test_base.CoriolisBaseTestCase):
             mock_parse_replicator_conn_info.return_value['port'],
             mock_setup_certificates.return_value['remote'],
             replicator_module.REPLICATOR_STATE)
-        mock_start.assert_called_once()
 
         self.assertEqual(result, mock_setup_certificates.return_value['local'])