Browse Source

osmorphing: Fix undefined attribute installed_packages

Cristian Matiut 1 year ago
parent
commit
846e388cd3

+ 1 - 2
coriolis/osmorphing/base.py

@@ -79,7 +79,7 @@ class BaseOSMorphingTools(object, with_metaclass(abc.ABCMeta)):
                 cls.__name__))
 
     @abc.abstractmethod
-    def get_installed_packages(self, package_name):
+    def get_installed_packages(self):
         pass
 
     @abc.abstractmethod
@@ -125,7 +125,6 @@ class BaseOSMorphingTools(object, with_metaclass(abc.ABCMeta)):
 class BaseLinuxOSMorphingTools(BaseOSMorphingTools):
 
     _packages = {}
-    installed_packages = []
 
     def __init__(self, conn, os_root_dir, os_root_dev, hypervisor,
                  event_manager, detected_os_info, osmorphing_parameters,

+ 1 - 1
coriolis/osmorphing/coreos.py

@@ -15,7 +15,7 @@ class BaseCoreOSMorphingTools(base.BaseLinuxOSMorphingTools):
         return False
 
     def get_installed_package(self):
-        pass
+        self.installed_packages = []
 
     def disable_predictable_nic_names(self):
         pass

+ 1 - 1
coriolis/osmorphing/debian.py

@@ -128,7 +128,7 @@ class BaseDebianMorphingTools(base.BaseLinuxOSMorphingTools):
             self.installed_packages = self._exec_cmd_chroot(
                 cmd).decode('utf-8').splitlines()
         except exception.CoriolisException:
-            pass
+            self.installed_packages = []
 
     def pre_packages_install(self, package_names):
         super(BaseDebianMorphingTools, self).pre_packages_install(

+ 1 - 1
coriolis/osmorphing/openwrt.py

@@ -18,7 +18,7 @@ class BaseOpenWRTMorphingTools(base.BaseLinuxOSMorphingTools):
         return False
 
     def get_installed_package(self):
-        pass
+        self.installed_packages = []
 
     def disable_predictable_nic_names(self):
         pass

+ 1 - 0
coriolis/osmorphing/redhat.py

@@ -217,6 +217,7 @@ class BaseRedHatMorphingTools(base.BaseLinuxOSMorphingTools):
         except exception.CoriolisException:
             LOG.warning("Failed to get installed packages")
             LOG.trace(utils.get_exception_details())
+            self.installed_packages = []
 
     def _yum_install(self, package_names, enable_repos=[]):
         try:

+ 1 - 0
coriolis/osmorphing/suse.py

@@ -73,6 +73,7 @@ class BaseSUSEMorphingTools(base.BaseLinuxOSMorphingTools):
         except exception.CoriolisException:
             LOG.warning("Failed to get installed packages")
             LOG.trace(utils.get_exception_details())
+            self.installed_packages = []
 
     def get_update_grub2_command(self):
         location = self._get_grub2_cfg_location()

+ 1 - 1
coriolis/osmorphing/windows.py

@@ -611,7 +611,7 @@ class BaseWindowsMorphingTools(base.BaseOSMorphingTools):
         return [], []
 
     def get_installed_packages(self):
-        pass
+        self.installed_packages = []
 
     def pre_packages_install(self, package_names):
         pass