2
0
Эх сурвалжийг харах

Fix missing TYPE argument and value in ifcfg files

Handle cases where TYPE is present but empty, as well as when TYPE is missing entirely from the ifcfg file.
Also including the case sensitive coverage and preventing any dict unexpected behaviors.
Emilian Bogdan 5 сар өмнө
parent
commit
51618e102f

+ 5 - 1
coriolis/osmorphing/netpreserver/ifcfg.py

@@ -52,6 +52,10 @@ class IfcfgNetPreserver(base.BaseNetPreserver):
         ifcfgs = []
         ifcfgs = []
         for ifcfg_file in self._get_net_config_files(network_scripts_path):
         for ifcfg_file in self._get_net_config_files(network_scripts_path):
             ifcfg = self.osmorphing_tool._read_config_file_sudo(ifcfg_file)
             ifcfg = self.osmorphing_tool._read_config_file_sudo(ifcfg_file)
-            if ifcfg.get("TYPE") == ifcfg_type:
+            detected_type = ifcfg.get('TYPE')
+            if not detected_type:
+                detected_type = "Ethernet"
+                ifcfg["TYPE"] = detected_type
+            if detected_type.lower() == ifcfg_type.lower():
                 ifcfgs.append((ifcfg_file, ifcfg))
                 ifcfgs.append((ifcfg_file, ifcfg))
         return ifcfgs
         return ifcfgs