Pārlūkot izejas kodu

Fix Minion Compatibility validation task

This patch fixes a bug where not all required task info properties would be
returned by `get_required_task_info_properties`, caused by the assumption that
the set `.union()` method would unionize in place, which in fact it does not.
Daniel Vincze 2 gadi atpakaļ
vecāks
revīzija
1935110ecb
1 mainītis faili ar 1 papildinājumiem un 1 dzēšanām
  1. 1 1
      coriolis/tasks/minion_pool_tasks.py

+ 1 - 1
coriolis/tasks/minion_pool_tasks.py

@@ -654,7 +654,7 @@ class _BaseValidateMinionCompatibilityTask(base.TaskRunner):
             "export_info",
             "export_info",
             cls._get_transfer_properties_task_info_field(),
             cls._get_transfer_properties_task_info_field(),
             cls._get_minion_properties_task_info_field()])
             cls._get_minion_properties_task_info_field()])
-        base_props.union(set(
+        base_props = base_props.union(set(
             cls._get_minion_task_info_field_mappings().keys()))
             cls._get_minion_task_info_field_mappings().keys()))
         return list(base_props)
         return list(base_props)