Răsfoiți Sursa

Raise error on provider not found

nuwang 2 ani în urmă
părinte
comite
9cf27eed31
2 a modificat fișierele cu 3 adăugiri și 5 ștergeri
  1. 1 4
      cloudbridge/factory.py
  2. 2 1
      tests/test_cloud_factory.py

+ 1 - 4
cloudbridge/factory.py

@@ -69,10 +69,7 @@ class CloudProviderFactory(object):
         """
         """
         for _, modname, _ in pkgutil.iter_modules(providers.__path__):
         for _, modname, _ in pkgutil.iter_modules(providers.__path__):
             log.debug("Importing provider: %s", modname)
             log.debug("Importing provider: %s", modname)
-            try:
-                self._import_provider(modname)
-            except Exception as e:
-                log.debug("Could not import provider: %s", e)
+            self._import_provider(modname)
 
 
     def _import_provider(self, module_name):
     def _import_provider(self, module_name):
         """
         """

+ 2 - 1
tests/test_cloud_factory.py

@@ -37,9 +37,10 @@ class CloudFactoryTestCase(unittest.TestCase):
         self.assertIsNone(CloudProviderFactory().get_provider_class("aws1"))
         self.assertIsNone(CloudProviderFactory().get_provider_class("aws1"))
 
 
     def test_find_provider_include_mocks(self):
     def test_find_provider_include_mocks(self):
+        providers = CloudProviderFactory().get_all_provider_classes()
         self.assertTrue(
         self.assertTrue(
             any(cls for cls
             any(cls for cls
-                in CloudProviderFactory().get_all_provider_classes()
+                in providers
                 if issubclass(cls, TestMockHelperMixin)),
                 if issubclass(cls, TestMockHelperMixin)),
             "expected to find at least one mock provider")
             "expected to find at least one mock provider")